[data-plane] refresh confidential-ledger-rest #32236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazrael2119
requested review from
bterlson,
a team and
joheredi
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
Looks good but @kazrael2119 do we have unit tests to add for this? |
@mpodwysocki we already have test cases https://github.com/Azure/azure-sdk-for-js/tree/c06e1ae50c2c00cddb5933690af3d5816d5a7f0b/sdk/confidentialledger/confidential-ledger-rest/test/public just didn't modify it in this PR and we don't have api change for the tests related apis. |
qiaozha
approved these changes
Dec 20, 2024
|
I think it should be okay to merge, @mpodwysocki let me know if you still have any concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30680