Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Route SDK for metadata accuracy, v2 alignment, and latest TypeScript SDK compatibility #31562

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Update Route SDK for metadata accuracy, v2 alignment, and latest TypeScript SDK compatibility #31562

merged 15 commits into from
Nov 19, 2024

Conversation

Lakicar95
Copy link
Contributor

@Lakicar95 Lakicar95 commented Oct 28, 2024 •
edited
Loading

This PR updates swagger.md to improve metadata accuracy and align with Customization v2 requirements. Key changes include adding +flavor: azure and + openapi-type: data-plane tags, updating the source-code-folder-path to generated for clearer organization, and setting @autorest/typescript to "latest" for compatibility with the newest TypeScript SDK features.

@github-actions github-actions bot added the Maps label Oct 28, 2024
@Lakicar95 Lakicar95 changed the title Refresh Route SDK Update Route SDK for metadata accuracy, v2 alignment, and latest TypeScript SDK compatibility Oct 28, 2024
@dubiety
Copy link
Member

dubiety commented Oct 28, 2024 •
edited
Loading

@Lakicar95 , I see in PR #31256 , it also imports some libraries in samples, like in samples/v1-beta/typescript/src/lro.ts, it imports import { __await } from "tslib";. Can you also help to update our sampes liek the PR does?

Also, can you help to update the white spaces like in #31256, samples/v1-beta/typescript/src/range.ts and samples/v1-beta/typescript/src/matrix.ts? Thanks!

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure-rest/maps-route

@Lakicar95
Copy link
Contributor Author

@Lakicar95 , I see in PR #31256 , it also imports some libraries in samples, like in samples/v1-beta/typescript/src/lro.ts, it imports import { __await } from "tslib";. Can you also help to update our sampes liek the PR does?

Also, can you help to update the white spaces like in #31256, samples/v1-beta/typescript/src/range.ts and samples/v1-beta/typescript/src/matrix.ts? Thanks!

@Lakicar95 Lakicar95 closed this Oct 29, 2024
@Lakicar95 Lakicar95 reopened this Oct 29, 2024
@Lakicar95
Copy link
Contributor Author

@Lakicar95 , I see in PR #31256 , it also imports some libraries in samples, like in samples/v1-beta/typescript/src/lro.ts, it imports import { __await } from "tslib";. Can you also help to update our sampes liek the PR does?

Also, can you help to update the white spaces like in #31256, samples/v1-beta/typescript/src/range.ts and samples/v1-beta/typescript/src/matrix.ts? Thanks!

Seems like: import { __await } from "tslib"; is unused and deprecated, native await will handle getLongRunningPoller

@dubiety
Copy link
Member

dubiety commented Nov 4, 2024

Please help to solve the merge conflict

@kazrael2119 kazrael2119 mentioned this pull request Nov 6, 2024
Closed
@Lakicar95 Lakicar95 enabled auto-merge (squash) November 15, 2024 03:23
MaryGao
MaryGao approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRO changes LGTM @jeremymeng could you review other parts?

@Lakicar95 Lakicar95 merged commit b6cfcc6 into Azure:main Nov 19, 2024
24 checks passed
@Lakicar95 Lakicar95 deleted the refresh_route branch November 19, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@andykao1213 andykao1213 andykao1213 approved these changes

@jeremymeng jeremymeng jeremymeng approved these changes

@dubiety dubiety dubiety approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

Assignees
No one assigned
Labels
Maps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Lakicar95 @dubiety @azure-sdk @jeremymeng @MaryGao @andykao1213