[communication] Move @azure/communication-common to ESM/vitest #31416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
a team,
ckairen,
jeremymeng,
bterlson,
dubiety,
andykao1213,
AikoBB,
maximrytych-ms and
mjafferi-msft
as code owners
|
API change check API changes are not detected in this pull request. |
- ~re-enable running samples~ [Will be deferred to another PR] - ~re-enable min/max testing~ [Will be deferred to another PR] - use service connection to enable cross-tenants testing Live run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4231515&view=results
### Packages impacted by this PR - `@azure/keyvault-common` - `@azure/keyvault-admin` - `@azure/keyvault-certificates` - `@azure/keyvault-keys` - `@azure/keyvault-secrets` Preparing for release of CAE support + ESM migration.
mpodwysocki
force-pushed
the
feat/communication-common-esm-vitest
branch
from
9f48944 to
de1c4a4
Compare
mpodwysocki
requested review from
deyaaeldeen,
minhanh-phan,
EmmaZhu,
XiaoningLiu,
vinjiang,
jiacfan,
ljian3377,
blueww,
maorleger and
timovv
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Updates to ESM/vitest for @azure/communication-common
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists