[data-plane] refresh load-testing-rest sdk #31029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
qiaozha
reviewed
Nov 7, 2024
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import { |
There was a problem hiding this comment.
why this file is newly added instead of moving from outside of generated folder ?
There was a problem hiding this comment.
this package was released when emitter was not fully ready
sdk/loadtesting/load-testing-rest/src/getTestRunCompletionPoller.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
…l2119/azure-sdk-for-js into refresh-load-testing-rest
kazrael2119
commented
Nov 11, 2024
| generate-test: true | ||
| license-header: MICROSOFT_MIT_NO_VERSION | ||
| output-folder: ../ | ||
| source-code-folder-path: ./src | ||
| input-file: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/loadtestservice/data-plane/Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json | ||
| input-file: https://github.com/Azure/azure-rest-api-specs/blob/3e27c70e7c02c07b458bc0e94716c3d82d3fdd19/specification/loadtestservice/data-plane/Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json |
qiaozha
changed the title
kazrael2119
commented
Dec 16, 2024
qiaozha
reviewed
Dec 19, 2024
| @@ -1,14 +1,9 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.0.1 (Unreleased) | |||
| ## 1.0.1 (2024-12-16) | |||
There was a problem hiding this comment.
Suggested change
| ## 1.0.1 (2024-12-16) | |
| ## 2.0.0 (2024-12-16) |
I think we should bump major version for it.
qiaozha
reviewed
Dec 19, 2024
| @@ -11,12 +11,10 @@ urlFragment: load-testing-javascript | |||
|
|
|||
| These sample programs show how to use the JavaScript client libraries for Azure Load Testing rest in some common scenarios. | |||
|
|
|||
| | **File Name** | **Description** | | |||
| | ----------------------------------------------------------- | -------------------------- | | |||
| | [createAppComponent.js][createappcomponent] | creates and run a loadtest | | |||
kazrael2119
requested review from
a team,
bterlson and
xirzec
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30680