-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate mgmt pacakge to esm #32184
Comments
we should confirm the diff of the migration command running against auto generated Modular. @kazrael2119 |
current manually work: update vitest.config.ts as
add
in vitest.browser.config.ts update all the scripts if it is mgmt modular:
update tsconfig.browser.config.json as if it is modular
updates unit-test:browser script as for hlc
remove |
#32184 @azure/arm-databox @azure/arm-databoxedge @azure/arm-databoxedge-profile-2020-09-01-hybrid @azure/arm-databricks @azure/arm-datacatalog
#32184 @azure/arm-appservice @azure/arm-appservice-profile-2020-09-01-hybrid @azure/arm-astro @azure/arm-attestation @azure/arm-authorization @azure/arm-authorization-profile-2020-09-01-hybrid
#32184 @azure/arm-automanage @azure/arm-analysisservices @azure/arm-automation @azure/arm-avs @azure/arm-azureadexternalidentities
#32184 @azure/arm-billingbenefits @azure/arm-botservice @azure/arm-cdn @azure/arm-changeanalysis @azure/arm-changes
#32184 @azure/arm-azurestack @azure/arm-azurestackhci @azure/arm-baremetalinfrastructure @azure/arm-batch @azure/arm-billing
#32184 @azure/arm-appcomplianceautomation @azure/arm-appconfiguration @azure/arm-appcontainers @azure/arm-appinsights @azure/arm-appplatform
#32184 @azure/arm-compute-profile-2020-09-01-hybrid @azure/arm-confidentialledger @azure/arm-confluent @azure/arm-connectedvmware
#32184 @azure/arm-chaos @azure/arm-cognitiveservices @azure/arm-commerce @azure/arm-commerce-profile-2020-09-01-hybrid @azure/arm-communication
#32184 @azure/arm-consumption @azure/arm-containerinstance @azure/arm-containerregistry @azure/arm-containerservice @azure/arm-containerservicefleet
#32184 @azure/arm-cosmosdbforpostgresql @azure/arm-costmanagement @azure/arm-customerinsights @azure/arm-dashboard @azure/arm-databoundaries
### Packages impacted by this PR - @azure/dev-tool ### Issues associated with this PR - #32184 ### Describe the problem that is addressed by this PR Addresses the feedback about the migration for the [ARM Migration](#32184 (comment)) ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
@kazrael2119 this should be addressed in this PR #32542 Let me know if there are other issues that we can address. |
#32550) ### Packages impacted by this PR - @azure/dev-tool - @azure/arm-voiceservices - @azure/arm-webpubsub - @azure/arm-workloads - @azure/arm-workloadssapvirtualinstance ### Issues associated with this PR - #32184 - #32416 ### Describe the problem that is addressed by this PR Updates the migration tool for ARM packages and updates snippets for the above packages. This adds the following for the migration tool. - Fixes for `samples-dev` to add `Promise<void>` to all non-marked methods - Change `beforeEach` and `afterEach` to use arrow functions instead of `function` - Fix the `timeout` issue on `it` and `it.skip` to move it to an options parameter. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
#32184 @azure/arm-datadog @azure/arm-datafactory @azure/arm-datalake-analytics @azure/arm-datamigration @azure/arm-dataprotection
#32184 @azure/arm-defendereasm @azure/arm-deploymentmanager @azure/arm-desktopvirtualization @azure/arm-devcenter @azure/arm-devhub
#32184 @azure/arm-deviceprovisioningservices @azure/arm-deviceupdate @azure/arm-devspaces @azure/arm-devtestlabs @azure/arm-digitaltwins
The text was updated successfully, but these errors were encountered: