Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Configuration] simulate the service throttling - honors the abort signal passed failing in nightly runs #31010

Open
jerryshia opened this issue Sep 6, 2024 · 0 comments
Open

[App Configuration] simulate the service throttling - honors the abort signal passed failing in nightly runs #31010

jerryshia opened this issue Sep 6, 2024 · 0 comments
Assignees
@HarshaNalluru @minhanh-phan
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable

Comments

@jerryshia
Copy link
Member

App Configuration nightly test runs are failing with:

Stack trace:
Unexpected error thrown: expected 'RestError' to equal 'AbortError'
+ expected - actual
-RestError
+AbortError
AssertionError: Unexpected error thrown: expected 'RestError' to equal 'AbortError'
at Context. (file:///Users/runner/work/1/s/sdk/appconfiguration/app-configuration/test/internal/node/throttlingRetryPolicy.spec.ts:63:19)
at processTicksAndRejections (node:internal/process/task_queues:105:5)

For more details check here:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4112660&view=results
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 6, 2024
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. App Configuration Azure.ApplicationModel.Configuration test-reliability Issue that causes tests to be unreliable and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 6, 2024
This was referenced Sep 11, 2024
Merged
Closed
minhanh-phan added a commit that referenced this issue Sep 17, 2024
@minhanh-phan
[App Config] Fix App Config Tests (#31079)
998eda5 
### Packages impacted by this PR
@azure/app-configuration

### Issues associated with this PR
#31010

### Describe the problem that is addressed by this PR
- Move away from nock mocking because of unexpected behavior change from
Node 22.7 and above.
- Update samples to avoid duplicate key error when the samples are run
in parallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarshaNalluru HarshaNalluru

@minhanh-phan minhanh-phan

Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HarshaNalluru @v-xuto @minhanh-phan @jerryshia