[ai-document-intelligence] Loading from an ESM module still doesn't seem to work fine. Still loads CJS

[nicu-chiciuc]

• Package Name: @azure-rest/ai-document-intelligence
• Package Version: 1.0.0-beta.2
• Operating system: macOS 14.4.1 (23E224)
• nodejs
  • version: v18.18.2
• browser
  • name/version:
• typescript
  • version:
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug

I'm using this tsconfig.json

{
  "extends": ["tsconfig/base-esm.json"],
  "exclude": ["node_modules"],
  "include": ["src", "scripts"],

  "compilerOptions": {
    "lib": ["ESNext"],

    "declaration": false,
    "declarationMap": false,

    "sourceMap": true,

    "checkJs": false,
    "allowJs": false,

    "rootDir": "./src",
    "outDir": "./dist",
  }
}

// base-esm.json
{
  "$schema": "https://json.schemastore.org/tsconfig",
  "display": "Pure ESM",
  "extends": "./base.json",
  "compilerOptions": {
    "lib": ["ESNext"],

    "module": "NodeNext",
    "target": "esnext",
    "moduleResolution": "NodeNext",

    "checkJs": true
  }
}

The TS files are translated directly to ESM without converting them to commonjs, since Node supports running ESM.

When trying to import the default function from '@azure-rest/ai-document-intelligence' I get a TS error if I want to call it directly:

using DocumentIntelligence.default() fixes this issue.

Since this is a monorepo, another projects imports this Node app (just for the types). And that causes issues, since that project is using Next.js, and as such is not yet converted to type: "module".

I've ran the Node project using NODE_DEBUG=esm to figure out which file is actually imported.

ESM 34908: Loading CJSModule file:///Users/nicu/dev/robo/robo-turbo/node_modules/.pnpm/@azure-rest+ai-document-intelligence@1.0.0-beta.2/node_modules/@azure-rest/ai-document-intelligence/dist/index.js

it seems that it's still loading the CJS file instead the one from /dist-esm/.

A simple solution would be to also provide a non-default export so these issues don't appear.

To Reproduce
Steps to reproduce the behavior:

1. Import the package in an ESM project.

Expected behavior
I expect to be able to import the project in an ESM project

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
given above

[xirzec]

@mpodwysocki will this be fixed by migration to ESM/tshy?

/cc @joheredi

[mpodwysocki]

@xirzec Yes, this will be fixed with a tshy migration