Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication - Chat]ChatThreadClient successfully sends read receipt failing in nightly runs #27210

Open
zzhxiaofeng opened this issue Sep 22, 2023 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Communication - Chat test-reliability Issue that causes tests to be unreliable

Comments

@zzhxiaofeng
Copy link
Contributor

Communication - Chat nightly test runs are failing with:

Error message:
{ "CommunicationError": { "Code": "NotFound", "Details": [] } }

Stack trace:
RestError: {
"CommunicationError": {
"Code": "NotFound",
"Details": []
}
}
at handleErrorResponse (D:\a_work\1\s\sdk\core\core-client\src\deserializationPolicy.ts:255:17)
at deserializeResponseBody (D:\a_work\1\s\sdk\core\core-client\src\deserializationPolicy.ts:159:43)
at processTicksAndRejections (node:internal/process/task_queues:95:5)

For more details check here:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3104913&view=results

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 22, 2023
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable Communication - Chat and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 22, 2023
@rjgotten
Copy link

Currently maybe being bitten by this.

It appears that I'm not receiving a proper "readReceiptReceived" event from the StatefulChatClient in @azure/communication-react at all -- and that implementation just proxies to the base ChatClient from @azure/communication-chat.

If I perform a listReadReceipts the read receipts are there - i.e. they were actually sent.
But the corresponding event is never properly raised.

This is making it impossible to implement a reliable way of reporting unread message count in UI, without manually tracking when a user has opened a particular chat thread in said UI -- and then just brute-force forcing an update that wipes a counter being kept for that thread ID, resetting it to 0. Simply assuming that because a particular chat thread received focus in the UI, all its messages were read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Communication - Chat test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

No branches or pull requests

4 participants