Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Restore-AzRecoveryServicesBackupItem to support NoZone as a valid TargetZone. #27010

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SourabhSomnathGholap
Copy link
Contributor

Description

Updated Restore-AzRecoveryServicesBackupItem to support NoZone as a valid TargetZone and restricted the input for TargetZoneNumber to 1, 2, 3, and NoZone.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jan 15, 2025

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Breaking Change Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation
Restore-AzRecoveryServicesBackupItem The cmdlet 'Restore-AzRecoveryServicesBackupItem' no longer supports the type 'System.Nullable`1[System.Int32]' for parameter 'TargetZoneNumber'. Change the type for parameter 'TargetZoneNumber' back to 'System.Nullable`1[System.Int32]'.
Restore-AzRecoveryServicesBackupItem A validate set has been added for parameter 'TargetZoneNumber' for cmdlet 'Restore-AzRecoveryServicesBackupItem'. Remove the validate set from parameter 'TargetZoneNumber'.
❌Windows PowerShell - Windows
Type Cmdlet Description Remediation
Restore-AzRecoveryServicesBackupItem The cmdlet 'Restore-AzRecoveryServicesBackupItem' no longer supports the type 'System.Nullable`1[System.Int32]' for parameter 'TargetZoneNumber'. Change the type for parameter 'TargetZoneNumber' back to 'System.Nullable`1[System.Int32]'.
Restore-AzRecoveryServicesBackupItem A validate set has been added for parameter 'TargetZoneNumber' for cmdlet 'Restore-AzRecoveryServicesBackupItem'. Remove the validate set from parameter 'TargetZoneNumber'.
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Restore-AzRecoveryServicesBackupItem 7 8 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. -WLRecoveryConfig Assign value for $AnotherInstanceWithLogConfig.
⚠️ Restore-AzRecoveryServicesBackupItem 9 4 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. -RestoreDiskList Assign value for $restoreDiskLUNs.
⚠️ Restore-AzRecoveryServicesBackupItem 12 3 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. -Item Assign value for $item.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Restore-AzRecoveryServicesBackupItem 7 8 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. -WLRecoveryConfig Assign value for $AnotherInstanceWithLogConfig.
⚠️ Restore-AzRecoveryServicesBackupItem 9 4 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. -RestoreDiskList Assign value for $restoreDiskLUNs.
⚠️ Restore-AzRecoveryServicesBackupItem 12 3 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. -Item Assign value for $item.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@SourabhSomnathGholap SourabhSomnathGholap marked this pull request as ready for review January 22, 2025 17:57
@YanaXu
Copy link
Contributor

YanaXu commented Jan 23, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu YanaXu added the Breaking Change Release This PR contains breaking change label Jan 23, 2025
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@SourabhSomnathGholap SourabhSomnathGholap added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Jan 24, 2025
Copy link

‼️ Do NOT use squash to merge this pull request. All the commits must be merged to the target branch.
‼️ Enable "Allow merge commits" in the pull request settings. Select "Merge Commits" to merge the PR. Then go back to settings and disable the option.

@SourabhSomnathGholap SourabhSomnathGholap added Do Not Merge 🚫 and removed Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. labels Jan 24, 2025
Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change Do Not Merge 🚫
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants