Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AppServiceScanner Managed Identity rules #218

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fixed AppServiceScanner Managed Identity rules #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions internal/scanners/asp/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,11 @@ func (a *AppServiceScanner) getAppRules() map[string]scanners.AzureRule {
Recommendation: "App Service should use Managed Identities",
Impact: scanners.ImpactMedium,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappservice.Site)
return c.Identity == nil || c.Identity.Type == nil || *c.Identity.Type == armappservice.ManagedServiceIdentityTypeNone, ""
// c := target.(*armappservice.Site)
// c.Identity == nil || c.Identity.Type == nil || *c.Identity.Type == armappservice.ManagedServiceIdentityTypeNone
// not working because SDK set's Identity to nil even when configured.
ok := scanContext.SiteConfig.Properties.ManagedServiceIdentityID != nil || scanContext.SiteConfig.Properties.XManagedServiceIdentityID != nil
return !ok, ""
},
Url: "https://learn.microsoft.com/en-us/azure/app-service/overview-managed-identity?tabs=portal%2Chttp",
},
Expand Down Expand Up @@ -377,8 +380,11 @@ func (a *AppServiceScanner) getFunctionRules() map[string]scanners.AzureRule {
Recommendation: "Function should use Managed Identities",
Impact: scanners.ImpactMedium,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappservice.Site)
return c.Identity == nil || c.Identity.Type == nil || *c.Identity.Type == armappservice.ManagedServiceIdentityTypeNone, ""
// c := target.(*armappservice.Site)
// c.Identity == nil || c.Identity.Type == nil || *c.Identity.Type == armappservice.ManagedServiceIdentityTypeNone
// not working because SDK set's Identity to nil even when configured.
ok := scanContext.SiteConfig.Properties.ManagedServiceIdentityID != nil || scanContext.SiteConfig.Properties.XManagedServiceIdentityID != nil
return !ok, ""
},
Url: "https://learn.microsoft.com/en-us/azure/app-service/overview-managed-identity?tabs=portal%2Chttp",
},
Expand Down Expand Up @@ -507,8 +513,11 @@ func (a *AppServiceScanner) getLogicRules() map[string]scanners.AzureRule {
Recommendation: "Logic App should use Managed Identities",
Impact: scanners.ImpactMedium,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappservice.Site)
return c.Identity == nil || c.Identity.Type == nil || *c.Identity.Type == armappservice.ManagedServiceIdentityTypeNone, ""
// c := target.(*armappservice.Site)
// c.Identity == nil || c.Identity.Type == nil || *c.Identity.Type == armappservice.ManagedServiceIdentityTypeNone
// not working because SDK set's Identity to nil even when configured.
ok := scanContext.SiteConfig.Properties.ManagedServiceIdentityID != nil || scanContext.SiteConfig.Properties.XManagedServiceIdentityID != nil
return !ok, ""
},
Url: "https://learn.microsoft.com/en-us/azure/app-service/overview-managed-identity?tabs=portal%2Chttp",
},
Expand Down
96 changes: 84 additions & 12 deletions internal/scanners/asp/rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,18 +401,42 @@ func TestAppServiceScanner_AppRules(t *testing.T) {
name: "AppServiceScanner Managed Identity None",
fields: fields{
rule: "app-016",
target: &armappservice.Site{
Identity: &armappservice.ManagedServiceIdentity{
Type: to.Ptr(armappservice.ManagedServiceIdentityTypeNone),
target: &armappservice.Site{},
scanContext: &scanners.ScanContext{
SiteConfig: &armappservice.WebAppsClientGetConfigurationResponse{
SiteConfigResource: armappservice.SiteConfigResource{
Properties: &armappservice.SiteConfig{
ManagedServiceIdentityID: nil,
},
},
},
},
scanContext: &scanners.ScanContext{},
},
want: want{
broken: true,
result: "",
},
},
{
name: "AppServiceScanner Managed Identity",
fields: fields{
rule: "app-016",
target: &armappservice.Site{},
scanContext: &scanners.ScanContext{
SiteConfig: &armappservice.WebAppsClientGetConfigurationResponse{
SiteConfigResource: armappservice.SiteConfigResource{
Properties: &armappservice.SiteConfig{
ManagedServiceIdentityID: to.Ptr(int32(1)),
},
},
},
},
},
want: want{
broken: false,
result: "",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down Expand Up @@ -651,18 +675,42 @@ func TestAppServiceScanner_FunctionRules(t *testing.T) {
name: "AppServiceScanner Managed Identity None",
fields: fields{
rule: "func-014",
target: &armappservice.Site{
Identity: &armappservice.ManagedServiceIdentity{
Type: to.Ptr(armappservice.ManagedServiceIdentityTypeNone),
target: &armappservice.Site{},
scanContext: &scanners.ScanContext{
SiteConfig: &armappservice.WebAppsClientGetConfigurationResponse{
SiteConfigResource: armappservice.SiteConfigResource{
Properties: &armappservice.SiteConfig{
ManagedServiceIdentityID: nil,
},
},
},
},
scanContext: &scanners.ScanContext{},
},
want: want{
broken: true,
result: "",
},
},
{
name: "AppServiceScanner Managed Identity",
fields: fields{
rule: "func-014",
target: &armappservice.Site{},
scanContext: &scanners.ScanContext{
SiteConfig: &armappservice.WebAppsClientGetConfigurationResponse{
SiteConfigResource: armappservice.SiteConfigResource{
Properties: &armappservice.SiteConfig{
ManagedServiceIdentityID: to.Ptr(int32(1)),
},
},
},
},
},
want: want{
broken: false,
result: "",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down Expand Up @@ -901,18 +949,42 @@ func TestAppServiceScanner_LogicRules(t *testing.T) {
name: "AppServiceScanner Managed Identity None",
fields: fields{
rule: "logics-014",
target: &armappservice.Site{
Identity: &armappservice.ManagedServiceIdentity{
Type: to.Ptr(armappservice.ManagedServiceIdentityTypeNone),
target: &armappservice.Site{},
scanContext: &scanners.ScanContext{
SiteConfig: &armappservice.WebAppsClientGetConfigurationResponse{
SiteConfigResource: armappservice.SiteConfigResource{
Properties: &armappservice.SiteConfig{
ManagedServiceIdentityID: nil,
},
},
},
},
scanContext: &scanners.ScanContext{},
},
want: want{
broken: true,
result: "",
},
},
{
name: "AppServiceScanner Managed Identity",
fields: fields{
rule: "logics-014",
target: &armappservice.Site{},
scanContext: &scanners.ScanContext{
SiteConfig: &armappservice.WebAppsClientGetConfigurationResponse{
SiteConfigResource: armappservice.SiteConfigResource{
Properties: &armappservice.SiteConfig{
ManagedServiceIdentityID: to.Ptr(int32(1)),
},
},
},
},
},
want: want{
broken: false,
result: "",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down
Loading