Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AppServiceScanner Managed Identity rules #218

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fixed AppServiceScanner Managed Identity rules #218

merged 1 commit into from
Apr 23, 2024

Conversation

cmendible
Copy link
Member

@cmendible cmendible commented Apr 23, 2024

Description

Fixed AppServiceScanner Managed Identity rules. The presence of managed identities must be checked via SiteConfig instead of the Identity property of the Sites object.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #211

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@cmendible cmendible self-assigned this Apr 23, 2024
@cmendible cmendible merged commit c906411 into main Apr 23, 2024
12 checks passed
@cmendible cmendible deleted the asp branch April 23, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed Identities rules form both app service and functions is reporting false positives
1 participant