Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #149 #165

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fixing #149 #165

merged 1 commit into from
Nov 10, 2023

Conversation

cmendible
Copy link
Member

Description

Added Public IPs to ScanContext so we can check Public IP properties when scanning services such as Load Balancer.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #149

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@cmendible cmendible merged commit ff5db9a into main Nov 10, 2023
12 checks passed
@cmendible cmendible deleted the issue-149 branch November 10, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loadbalancer Public IP with Zones enabled
1 participant