-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge scenarios #192
Conversation
- deployAseV3 param added
- added NSGs
@kunalbabre this is the link of the custom UX to test the deployment on portal |
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thodoris Theodorou <thotheod@microsoft.com> Co-authored-by: Jin Lee <94473824+JinLee794@users.noreply.github.com>
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Tested thoroughly, made several fixes. Bicep Implementation of merged scenarios (together with OpenAI) seems fine now. Pasting the the test link for the Portal Custom Deployment |
* feat: ASE shared modules (CARML) - deployAseV3 param added * feat: fixed spoke subnets - added NSGs * doc: changes for deployAseV3 * fix: typo * doc: settings * fix * fx * feat: asp merged - test 1 * fix: nsg * fix zone redundant * fix: private DNS Zone * feat: merged scenarios BICEP * feat: portal deployment * fix * feat: deployAse Merged * fix * Removed (most of) ASEV3 scenario * test actions * action test * get latest from main (#193) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thodoris Theodorou <thotheod@microsoft.com> Co-authored-by: Jin Lee <94473824+JinLee794@users.noreply.github.com> * test * there is Scenario 2 - WF needs to be updated or deleted * fix: fix depedencies * depedency and conditional logic fix * ARM sync * Updated main readme * ok * allow non-AZ ASE * sync ARM * fix: zone redundant or not support for ASE * sync json * fix: dependency error * fix typo in condition * test ASE Private DNS Zone Dependency * fix dependencies * fix * ASE Private DNS Zone must be in same scope as ASE * test * fix outputs --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jin Lee <94473824+JinLee794@users.noreply.github.com> Co-authored-by: Jin Lee <jinle@microsoft.com>
* feat: ASE shared modules (CARML) - deployAseV3 param added * feat: fixed spoke subnets - added NSGs * doc: changes for deployAseV3 * fix: typo * doc: settings * fix * fx * feat: asp merged - test 1 * fix: nsg * fix zone redundant * fix: private DNS Zone * feat: merged scenarios BICEP * feat: portal deployment * fix * feat: deployAse Merged * fix * Removed (most of) ASEV3 scenario * test actions * action test * get latest from main (#193) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thodoris Theodorou <thotheod@microsoft.com> Co-authored-by: Jin Lee <94473824+JinLee794@users.noreply.github.com> * test * there is Scenario 2 - WF needs to be updated or deleted * fix: fix depedencies * depedency and conditional logic fix * ARM sync * Updated main readme * ok * allow non-AZ ASE * sync ARM * fix: zone redundant or not support for ASE * sync json * fix: dependency error * fix typo in condition * test ASE Private DNS Zone Dependency * fix dependencies * fix * ASE Private DNS Zone must be in same scope as ASE * test * fix outputs --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jin Lee <94473824+JinLee794@users.noreply.github.com> Co-authored-by: Jin Lee <jinle@microsoft.com>
Merged scenarios in one