Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding function to change multipath policy #207

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Malika133
Copy link

@Malika133 Malika133 commented Sep 4, 2023

This PR closes #

The changes in this PR are as follows:

Added powershell function to set Multipath Policy to Round Robin.

I have read the contributor guidelines and have completed the following:

  • Formatted the code using VSCode default formatter for PowerShell.
  • Tested the code end-to-end against an SDDC.
  • Documented the functions using standard PowerShell markup and applied AVSAttribute to newly exported functions.

@Malika133 Malika133 force-pushed the mchhibber/changeMultipathPolicy branch from 7907b0d to 3f475b8 Compare September 11, 2023 09:44
et1975
et1975 previously approved these changes Sep 13, 2023
@prtyag
Copy link

prtyag commented Sep 14, 2023

Before merging this PR make sure to add the testing detail and scenarios you covered in testing.

if ([string]::IsNullOrEmpty($MultipathPolicy) -or (-not $IsValidMultipathPolicy)){
Write-Warning "Either no or invalid multipath policy specified. Valid policies are: $($ValidMultipathPolicies -join ', '). Using default policy."
}
else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the code through formatting again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants