-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding function to change multipath policy #207
Open
Malika133
wants to merge
9
commits into
main
Choose a base branch
from
mchhibber/changeMultipathPolicy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abel-lb
reviewed
Sep 4, 2023
et1975
reviewed
Sep 5, 2023
Malika133
force-pushed
the
mchhibber/changeMultipathPolicy
branch
from
September 11, 2023 09:44
7907b0d
to
3f475b8
Compare
…Azure/Microsoft.AVS.Management into mchhibber/changeMultipathPolicy
et1975
reviewed
Sep 11, 2023
et1975
reviewed
Sep 11, 2023
et1975
previously approved these changes
Sep 13, 2023
Before merging this PR make sure to add the testing detail and scenarios you covered in testing. |
et1975
reviewed
Sep 19, 2023
if ([string]::IsNullOrEmpty($MultipathPolicy) -or (-not $IsValidMultipathPolicy)){ | ||
Write-Warning "Either no or invalid multipath policy specified. Valid policies are: $($ValidMultipathPolicies -join ', '). Using default policy." | ||
} | ||
else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the code through formatting again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #
The changes in this PR are as follows:
Added powershell function to set Multipath Policy to Round Robin.
I have read the contributor guidelines and have completed the following:
AVSAttribute
to newly exported functions.