test: Change test to check for kubelet.service file existence as well. #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwolffe
requested review from
alexeldeib,
juan-lee,
AbelHu and
thomas1206
as code owners
maxwolffe
force-pushed
the
add_kubelet_service
branch
from
52195e7 to
17b8f76
Compare
|
@alexeldeib - updated the commit messages to pass linting - could you re-approve tests at your convenience? Also - e2e tests failed on the last run due to az login failed - any other follow up I need to make there? |
|
unfortunately we have some annoying rbac issues running the e2e/generated tests from forks today :( the lint is fine after rebase, I'm about to break it again by clicking the rebase button but will squash-merge and ignore the other bit for now. |
tl;dr - always today. the token itself is generated by RP, so it's possible the field in the struct is empty. but that's never the case today anymore afaik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What this PR does / why we need it:
This PR adds a little more context to the test added in #3104 for issue #2815
The issue #2815 describes the full set of currently required data for custom images which don't rely on the CSE script to execute.
Those are:
The Databricks usecase also has a silly dependency on kubelet.service which I have removed and will roll out in the next month. I've added it as a required file for now, but happy to not if it's possible to otherwise prevent it from being removed in the near term?
/opt/azure/containers/kubelet.shalso shouldn't be required, but currently is because it's referenced by the kubelet.service.Which issue(s) this PR fixes:
None
Requirements:
Special notes for your reviewer:
First PR in this repo so apologies if I'm missing something / happy to make changes.
I've confirmed that tests failed first, then passed with this change.
I have a potentially dumb question about TLSBootstrapping being enabled. Under what conditions is it NOT enabled?
Found this -
AgentBaker/pkg/agent/utils.go
Line 355 in a7df3d6
Thanks!
Release note: