ARO-15000 | Add no-CNI support to frontend #1242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgiradkar
force-pushed
the
ARO-15000-add-no-cni-capability-frontend
branch
from
25f3633 to
49d113e
Compare
bennerv
reviewed
Feb 5, 2025
cgiradkar
force-pushed
the
ARO-15000-add-no-cni-capability-frontend
branch
from
49d113e to
d2472c9
Compare
cgiradkar
requested review from
jharrington22,
SudoBrendan and
UlrichSchlueter
as code owners
cgiradkar
changed the title
cgiradkar
changed the title
bennerv
reviewed
Feb 12, 2025
|
Please rebase pull request. |
cgiradkar
force-pushed
the
ARO-15000-add-no-cni-capability-frontend
branch
from
d2472c9 to
0ff484b
Compare
Made changes in the demo script files to form cluster creation payload accordingly if $NETWORK_TYPE is redefined. Made changes in the frontend code to accept network-type from boolean url paramemeter "nocni". Signed-off-by: Chetan Giradkar <cgiradka@redhat.com>
cgiradkar
force-pushed
the
ARO-15000-add-no-cni-capability-frontend
branch
from
0ff484b to
d30b7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes in the demo script files to form cluster creation payload accordingly if $NETWORK_TYPE is redefined.
What this PR does
Jira: ARO-15000
Link to demo recording:
Special notes for your reviewer
Since the no-CNI feature depends solely on cluster creation payload, the only change needed here was to update demo scripts.