Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env tip #20

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove env tip #20

wants to merge 4 commits into from

Conversation

russd2357
Copy link
Collaborator

Purpose

Remove the content about env files that were missed in an earlier PR. I replaced this with a section on how to generate environment variables for resource names and ids for resources created in the Bicep template. Modified the Bicep template to add outputs for users to access these values.

  • ...

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

For content

  1. Clone the repo
  2. Build and run the server
  3. Verify the env file related content is removed and the replacement content is present.
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
npm run start

Bicep template

  1. Deploy the Bicep template
  2. Run az deployment group show -g $RG_NAME -n $DEPLOYMENT_NAME --query properties.outputs to verify the outputs are present.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant