Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add wasm memory benchmark to bench.json (redo) #12205

Merged
merged 2 commits into from
Feb 22, 2025
Merged

feat: add wasm memory benchmark to bench.json (redo) #12205

merged 2 commits into from
Feb 22, 2025
+123 −69

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Feb 21, 2025

Reinstates #11551 with e2e-all flag to test bench running.

@ludamad ludamad requested a review from charlielye as a code owner February 21, 2025 22:56
@ludamad ludamad added the e2e-all CI: Deprecated, use ci-full. Enable all master checks. label Feb 21, 2025
lucasxia01
lucasxia01 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@lucasxia01 lucasxia01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good if bench passes

@ludamad ludamad merged commit b35a61d into master Feb 22, 2025
9 checks passed
@ludamad ludamad deleted the revert-12204-revert-11551-lx/wasm-memory-bench branch February 22, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasxia01 lucasxia01 lucasxia01 approved these changes

@charlielye charlielye Awaiting requested review from charlielye charlielye is a code owner

Assignees
No one assigned
Labels
e2e-all CI: Deprecated, use ci-full. Enable all master checks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludamad @lucasxia01