chore: address extra decryption oracle pr comments #12065
Merged
+72
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Feb 18, 2025
nventuro
reviewed
Feb 20, 2025
Comment on lines
+118
to
+119
| let extracted_mac_as_bytes: [u8; TEST_MAC_LENGTH] = | ||
| subarray(received_plaintext.storage(), TEST_PLAINTEXT_LENGTH); |
There was a problem hiding this comment.
subarray? I think its constraints can be improved, but sure!
nventuro
approved these changes
Feb 21, 2025
iAmMichaelConnor
deleted the
mc/address-decryption-oracle-extra-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11907 extra comments after merge