Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(avm): sha256 round read #12032

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat(avm): sha256 round read #12032

merged 1 commit into from
Feb 21, 2025

Conversation

IlyasRidhuan
Copy link
Contributor

@IlyasRidhuan IlyasRidhuan commented Feb 16, 2025 •
edited by fcarreiro
Loading 

----------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations
----------------------------------------------------------------------------
alu_acc                                0.123 us        0.123 us      5704410
bc_decomposition_acc                    11.1 us         11.1 us        64125
bc_decomposition_interactions_acc       1.11 us         1.11 us       609401
bc_retrieval_acc                       0.024 us        0.024 us     28989470
bitwise_acc                             1.54 us         1.54 us       463804
bitwise_interactions_acc               0.931 us        0.930 us       747686
ecc_acc                                 2.60 us         2.60 us       268130
execution_acc                          0.520 us        0.520 us      1344564
instr_fetching_acc                     0.024 us        0.024 us     29077799
poseidon2_hash_acc                      1.86 us         1.86 us       376737
poseidon2_hash_interactions_acc        0.744 us        0.744 us       943376
poseidon2_perm_acc                      43.7 us         43.7 us        15756
range_check_acc                         2.73 us         2.73 us       257574
range_check_interactions_acc            3.53 us         3.53 us       198019
sha256_acc                              6.22 us         6.21 us       112186
sha256_interactions_acc                0.401 us        0.401 us      1750988

@IlyasRidhuan Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IlyasRidhuan IlyasRidhuan force-pushed the ir/02-16-feat_sha256_round_read branch from 35bb303 to 400874c Compare February 17, 2025 16:18
@IlyasRidhuan IlyasRidhuan marked this pull request as ready for review February 17, 2025 16:18
@IlyasRidhuan IlyasRidhuan removed the request for review from Maddiaa0 February 17, 2025 16:18
fcarreiro
fcarreiro approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@fcarreiro fcarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just requesting some changes but approving already.

@fcarreiro fcarreiro changed the title feat: sha256 round read feat(avm): sha256 round read Feb 18, 2025
@IlyasRidhuan IlyasRidhuan force-pushed the ir/02-16-feat_sha256_round_read branch 4 times, most recently from fc9cd5c to 0940b54 Compare February 21, 2025 14:35
@IlyasRidhuan IlyasRidhuan force-pushed the ir/02-16-feat_sha256_round_read branch from 0940b54 to f97b4c6 Compare February 21, 2025 14:54
@IlyasRidhuan IlyasRidhuan merged commit 88b5878 into master Feb 21, 2025
10 checks passed
@IlyasRidhuan IlyasRidhuan deleted the ir/02-16-feat_sha256_round_read branch February 21, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcarreiro fcarreiro fcarreiro approved these changes

@jeanmon jeanmon Awaiting requested review from jeanmon jeanmon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyasRidhuan @fcarreiro