feat: add wasm memory benchmark to bench.json #11551
Merged
+120
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasxia01
commented
Jan 28, 2025
| "iterations": 1, | ||
| "real_time": last_memory, | ||
| "cpu_time": last_memory, | ||
| "time_unit": "ns" |
There was a problem hiding this comment.
I have no idea how this info is converted to the value in the data.js in the gh-pages branch. I tried looking for it in the github-action-benchmark repo but couldn't
ludamad
reviewed
Feb 21, 2025
| export -f ultra_honk_wasm_memory run_benchmark | ||
| local num_cpus=$(get_num_cpus) | ||
| local jobs=$((num_cpus / HARDWARE_CONCURRENCY)) | ||
| parallel -v --line-buffer --tag --jobs "$jobs" run_benchmark {#} {} ::: \ |
There was a problem hiding this comment.
Why parallel with one job
There was a problem hiding this comment.
I anticipate adding more
ludamad
reviewed
Feb 21, 2025
| @@ -64,6 +64,9 @@ case "$cmd" in | |||
| "hash") | |||
| echo "$hash" | |||
| ;; | |||
| "bench") | |||
| echo "ts/bootstrap.sh bench is empty" | |||
There was a problem hiding this comment.
I would have just printed nothing, the user will try and act on this maybe
ludamad
approved these changes
Feb 21, 2025
ludamad
added a commit
that referenced
this pull request
Feb 22, 2025
Reinstates #11551 with e2e-all flag to test bench running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify our benchmarking flow in CI for our bench json so that we include wasm benchmark on an acir test.