-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly Support Multiple File Types #33
Commits on Sep 11, 2023
-
External providers now use injected file helper
Now they support both types of file names
Configuration menu - View commit details
-
Copy full SHA for a16c27e - Browse repository at this point
Copy the full SHA a16c27eView commit details -
Providers now use localization parsers
So now they can support whatever has been registered
Configuration menu - View commit details
-
Copy full SHA for d0fa7c5 - Browse repository at this point
Copy the full SHA d0fa7c5View commit details -
Config is now registered with external provider
This puts less responsibility on the provider libraries and more on the initial bootstrap process. Renamed IExternalConfiguration to IExternalProviderConfiguration
Configuration menu - View commit details
-
Copy full SHA for 37c322a - Browse repository at this point
Copy the full SHA 37c322aView commit details
Commits on Sep 12, 2023
-
Added Tests For Helper Classes
Added loads of tests to cover various bits I refactored or added
Configuration menu - View commit details
-
Copy full SHA for 95fdf35 - Browse repository at this point
Copy the full SHA 95fdf35View commit details
Commits on Sep 13, 2023
-
Added Tests For Localization Parsers
Added tests for all of the localization parsers, I will then implemented the resx one afterwards
Configuration menu - View commit details
-
Copy full SHA for 25e9a5a - Browse repository at this point
Copy the full SHA 25e9a5aView commit details
Commits on Sep 14, 2023
-
We can now read downloaded resx strings. This was way more awkward than I imagined it to be, I will rip the parts of the lib I referenced to prevent the dependency!
Configuration menu - View commit details
-
Copy full SHA for 4d690e9 - Browse repository at this point
Copy the full SHA 4d690e9View commit details -
These tests were broken from refactors so theyre now working again
Configuration menu - View commit details
-
Copy full SHA for 6501a95 - Browse repository at this point
Copy the full SHA 6501a95View commit details
Commits on Sep 20, 2023
-
I realised that resx would need its own custom file name logic so I refactored the config to have an object for the filetype details. This has had some knock on effects but means it should be easier supporting unique file types in the future.
Configuration menu - View commit details
-
Copy full SHA for 1ce933b - Browse repository at this point
Copy the full SHA 1ce933bView commit details -
Fix culture issue & add external resx to sample
The version formatting didn't apply to primary cultures and the culture checking didn't work properly despite the unit tests passing so I have updated the tests to be flakier and fixed the offending code (using ==). Added resx files for external demonstration
Configuration menu - View commit details
-
Copy full SHA for be2fb74 - Browse repository at this point
Copy the full SHA be2fb74View commit details -
There is now an example of config for each type of file
Configuration menu - View commit details
-
Copy full SHA for 960fade - Browse repository at this point
Copy the full SHA 960fadeView commit details
Commits on Sep 21, 2023
-
Updated Host Builder Method Docs
I have been neglecting these so here are some for the most used methods
Configuration menu - View commit details
-
Copy full SHA for eabd25c - Browse repository at this point
Copy the full SHA eabd25cView commit details