Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly Support Multiple File Types #33

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Properly Support Multiple File Types #33

merged 11 commits into from
Sep 21, 2023

Commits on Sep 11, 2023

  1. External providers now use injected file helper

    Now they support both types of file names
    Axemasta committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a16c27e View commit details
    Browse the repository at this point in the history
  2. Providers now use localization parsers

    So now they can support whatever has been registered
    Axemasta committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d0fa7c5 View commit details
    Browse the repository at this point in the history
  3. Config is now registered with external provider

    This puts less responsibility on the provider libraries and more on the initial bootstrap process. Renamed IExternalConfiguration to IExternalProviderConfiguration
    Axemasta committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    37c322a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Added Tests For Helper Classes

    Added loads of tests to cover various bits I refactored or added
    Axemasta committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    95fdf35 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Added Tests For Localization Parsers

    Added tests for all of the localization parsers, I will then implemented the resx one afterwards
    Axemasta committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    25e9a5a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Implemented Resx Parser

    We can now read downloaded resx strings. This was way more awkward than I imagined it to be, I will rip the parts of the lib I referenced to prevent the dependency!
    Axemasta committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    4d690e9 View commit details
    Browse the repository at this point in the history
  2. Fixed Github Provider Tests

    These tests were broken from refactors so theyre now working again
    Axemasta committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6501a95 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Refactored File Details

    I realised that resx would need its own custom file name logic so I refactored the config to have an object for the filetype details. This has had some knock on effects but means it should be easier supporting unique file types in the future.
    Axemasta committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1ce933b View commit details
    Browse the repository at this point in the history
  2. Fix culture issue & add external resx to sample

    The version formatting didn't apply to primary cultures and the culture checking didn't work properly despite the unit tests passing so I have updated the tests to be flakier and fixed the offending code (using ==). Added resx files for external demonstration
    Axemasta committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    be2fb74 View commit details
    Browse the repository at this point in the history
  3. Reset sample config

    There is now an example of config for each type of file
    Axemasta committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    960fade View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Updated Host Builder Method Docs

    I have been neglecting these so here are some for the most used methods
    Axemasta committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    eabd25c View commit details
    Browse the repository at this point in the history