Enable light dismiss on CalendarDatePicker popup in simple theme #18092
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it with the |
|
You can test this PR using the following package version. |
timunie
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This sets
IsLightDismissEnabledtoTrueon the popup of theCalendarDatePickercontrol when using the simple theme. This was likely caused by the replacement of theStaysOpenproperty which was set to false. Link to the issue: #18066What is the current behavior?
IsLightDismissEnabledis set toFalsewhich in turn does not allow to auto close the popup when clicking outside of its bounds.What is the updated/expected behavior with this PR?
The popup now closes when using the
simpletheme and clicking outside of its bounds. This was the behavior bevor the commit that introduced this bug.Checklist
Fixed issues
Fixes #18066