-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automation pallets #2
Conversation
77f8529
to
e7c2f66
Compare
e7c2f66
to
9f9b8f7
Compare
c67f2b3
to
c437244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, but the name change comments need to be addressed.
oak-primitives/Cargo.toml
Outdated
@@ -0,0 +1,42 @@ | |||
[package] | |||
name = "oak-primitives" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t use this name oak
any more. This needs to be "ava-protocol-primitives".
It always need to be "ava-protocol", but can’t be "ava".
oak-primitives/Cargo.toml
Outdated
[package] | ||
name = "oak-primitives" | ||
version = "1.0.0" | ||
description = "OAK Runtime primitives" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace all "OAK" to "Ava Protocol"
oak-primitives/Cargo.toml
Outdated
description = "OAK Runtime primitives" | ||
authors = ["OAK Developement Team"] | ||
license = "GPL-3.0" | ||
homepage = "https://oak.tech" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update website
oak-primitives/Cargo.toml
Outdated
name = "oak-primitives" | ||
version = "1.0.0" | ||
description = "OAK Runtime primitives" | ||
authors = ["OAK Developement Team"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ava Protocol Team
oak-primitives/Cargo.toml
Outdated
authors = ["OAK Developement Team"] | ||
license = "GPL-3.0" | ||
homepage = "https://oak.tech" | ||
repository = 'https://github.com/OAK-Foundation/OAK-blockchain' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo address is wrong.
6bf5457
to
886106d
Compare
pallets/automation-time/Cargo.toml
Outdated
authors = ["Ava Protocol Team"] | ||
license = "GPL-3.0" | ||
homepage = "https://avaprotocol.org" | ||
repository = 'https://github.com/AvaProtocol/OAK-blockchain' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this repo address has changed, not OAK-blockchain any more.
Please examine all other "oak" references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
32f8cb8
to
b3f039b
Compare
0f47aba
to
1d35a6b
Compare
1d35a6b
to
becd2b5
Compare
5ee7cf7
to
5f2f1f0
Compare
d4b2c46
to
66091cf
Compare
66091cf
to
0b9dd08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Development
patch polkadot: OK
pallet-valve: compile success
pallet-xcmp-handler: compile success
oak-primitives: compile success
pallet-autmation-time: compile success
runtime-common: compile success
Add orml-asset-registry to runtime: compile success
Add orml-xtokens to runtime: compile success
Add pallet-xcmp-handler to runtime: compile success
Add pallet-autmation-time to runtime: compile success
Remove unused patch: OK
Launch chain with moonwall: OK
Run zombie_tanssi with moonwall
rust version: rustc 1.75.0
Typescript tests are run with Moonwall. To run these you will need to have pnpm installed:
https://polkadot.js.org/apps/?rpc=ws://127.0.0.1:9949#/explorer
https://polkadot.js.org/apps/?rpc=ws%3A%2F%2F127.0.0.1%3A9949#/extrinsics/decode/0xce030004903dcb66000000000a00008eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a480b0060defb7405
Unit Tests
pallet-xcmp-handler
pallet-automation-time
github actions:
CI / set-tags (pull_request): Fixed
Enforce PR labels / enforce-noteworthiness-label (pull_request): Fixed
CI / check-copyright (pull_request) : Fixed
Enforce PR labels / enforce-auditability-label (pull_request) : Fixed
CI / Check with rustfmt (pull_request): Fixed
CI / check-copyright (pull_request): Fixed
CI / toml-formatting (pull_request): Fixed
CI / cargo-clippy (pull_request) : Fixed