Fixed test failures caused by disallowing trigger of Completed status and bump up sdk-js version #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisli30
commented
Jan 24, 2025
| @@ -159,6 +153,7 @@ describe("getExecutions Tests", () => { | |||
| ...WorkflowTemplate, | |||
| trigger, | |||
| smartWalletAddress: wallet.address, | |||
| maxExecution: 1000, // Set a high maxExecution to ensure the workflow is not completed; otherwise, mannually triggering a completed workflow will fail | |||
There was a problem hiding this comment.
This is the second test: getExecutions Tests › options.cursor works as pagination
Simply adding this line makes the tests pass.
There was a problem hiding this comment.
yup that what i mean on the chat. the error was
9 FAILED_PRECONDITION: The workflow is not in a runable status, it has reached the limit execution or the expiration time
so we just need to fix it.
There was a problem hiding this comment.
should we set it to 0? maxExeuctio = 0 mean unlimited run. the default instead of setting a big enough number like 1000
There was a problem hiding this comment.
Yeah, you are right. 0 is better. Let me update this value.
vinh-recurve
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.