Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for disallowing manual trigger of completed tasks #57

Open
chrisli30 opened this issue Jan 24, 2025 · 2 comments
Open

Add tests for disallowing manual trigger of completed tasks #57

chrisli30 opened this issue Jan 24, 2025 · 2 comments
Assignees
Labels
P3 Priority 3

Comments

@chrisli30
Copy link
Member

chrisli30 commented Jan 24, 2025

The goal is to add tests for senarios around maxExecution: AvaProtocol/EigenLayer-AVS#110

This PR: #58 added a single fix to the existing tests.

@v9n let’s add a few tests to cover the new code.

@chrisli30 chrisli30 added the P2 Priority 2 label Jan 24, 2025
@v9n
Copy link
Member

v9n commented Jan 25, 2025

@chrisli30 what do you mean to add the test?

do you mean to replicate this to the sdk ?

In the AVS we had this test

  1. It set the max exectuiton to 1
  2. It triggerd. first time succeed
  3. trigger again and this time it should failed

Image

Do you mean to do the same in here?

@chrisli30
Copy link
Member Author

Yes, basically add the same test logic to tests/triggerWorkflow.test.ts. I’m updating it to P3, since it’s already tested in the AVS.

@chrisli30 chrisli30 added P3 Priority 3 and removed P2 Priority 2 labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority 3
Projects
None yet
Development

No branches or pull requests

2 participants