Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize cache enable/disable and update_mod_rewrite_rules #500

Conversation

stodorovic
Copy link

@stodorovic stodorovic commented Dec 16, 2017

  • Don't show htaccess form if cache is disabled. It doesn't make sense to update rewrite rules in this case.
  • Don't get test pages if $add_rules is false.
  • Cleanup/Optimize wp_cache_enable, wp_cache_disable, wp_super_cache_enable, wp_super_cache_disable.
  • Remove rewrite rules if caching is disabled.

@stodorovic stodorovic changed the title Don't show htaccess form if cache is disabled Optimize cache enable/disable and update_mod_rewrite_rules Dec 18, 2017
@donnchawp
Copy link
Contributor

Thanks again! You're really digging into some old code here.

Those calls to wp_cache_replace_line() could even be replaced with calls to wp_cache_setting() now.

And this proves how old some of this code is, I'm pretty sure WordPress doesn't have a gzipcompression option any more!

@stodorovic
Copy link
Author

It'll be possible after merging #487. I think that current wp_cache_setting doesn't support boolean.

@donnchawp donnchawp merged commit d66c898 into Automattic:master Feb 14, 2018
@stodorovic stodorovic deleted the dont-show-htaccess-form-when-is-disabled branch December 8, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants