-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Update several /client
components to replace formatNumnber
with i18n-calypso numberFormat
#99156
base: update/fix-number-format-a8c-for-agencies
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~400 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1096 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Part of addressing https://github.com/Automattic/i18n-issues/issues/934
Proposed Changes
@automattic/components:formatNumber
instances to go throughi18n-calypso:numberFormat
Why are these changes being made?
See https://github.com/Automattic/i18n-issues/issues/934
Testing Instructions
Various cases need to be tested separately, but one or two should suffice as they are all the same.
/devdocs
Blocks and confirmAuthorCompactProfile
renders subscribers count without decimalsPre-merge Checklist