-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: update Woo logo #99150
base: trunk
Are you sure you want to change the base?
A4A: update Woo logo #99150
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~6926 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -283,7 +284,7 @@ export default function ProductListing( { | |||
|
|||
{ wooExtensions.length > 0 && ( | |||
<ProductListingSection | |||
icon={ <WooLogo width={ 45 } height={ 28 } /> } | |||
icon={ <img width="45px" src={ WooCommerceLogo } alt="WooCommerce" /> } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should just update the component here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo reference in A4A has been updated, but I'm concerned that we now have more files to monitor when we have another rebrand later.
Since this is time-sensitive, I'll go ahead and approve the PR, but we should publish a P2 and coordinate with the larger group to clean up later. I see multiple Woo logo components. We should probably update those and only use one file.
p1738305279202359-slack-C047ACYM8UQ
? { | ||
regular: WooCommerceLogo, | ||
light: WooCommerceLogo, | ||
} | ||
: { | ||
regular: WooCommerceProductIcon, | ||
light: WooCommerceProductIcon, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is safe to update this for all environments. If I'm not mistaken, we only referenced Woo product icon in A4A currently.
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1716
Proposed Changes
This PR updates the old Woo logo with the newly updated one at the following places:
Overview page
Marketplace (products) - Category card
Marketplace (products) - Extension headline
Marketplace (modal) - product listing icon
Checkout - product listing icon
Referrals - Dashboard empty state
Referrals (FAQ) - 2 cards
Partner Directory (dashboard) - Woo card
Why are these changes being made?
Testing Instructions
Overview >
Products
sectionMarketplace > Products > Categories
Marketplace > Products > Extension headline
Marketplace > Products > Product listing modal for WooCommerce product
Marketplace > Checkout > WooCommerce products
Referrals > Dashboard empty state
Referrals > FAQ - 2 cards
Partner Directory > Dashboard - Woo card
Pre-merge Checklist