Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: update Woo logo #99150

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

A4A: update Woo logo #99150

wants to merge 1 commit into from

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Jan 31, 2025

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1716

Proposed Changes

This PR updates the old Woo logo with the newly updated one at the following places:

Overview page
Marketplace (products) - Category card
Marketplace (products) - Extension headline
Marketplace (modal) - product listing icon
Checkout - product listing icon
Referrals - Dashboard empty state
Referrals (FAQ) - 2 cards
Partner Directory (dashboard) - Woo card

Why are these changes being made?

  • To use the newly updated Woo logo

Testing Instructions

  • Open the A4A live link
  • Go to the below mentioned pages > Verify the logo is updated

Overview > Products section

Screenshot 2025-01-31 at 11 12 37 AM

Marketplace > Products > Categories

Screenshot 2025-01-31 at 11 12 15 AM

Marketplace > Products > Extension headline

Screenshot 2025-01-31 at 11 12 02 AM

Marketplace > Products > Product listing modal for WooCommerce product

Screenshot 2025-01-31 at 11 11 14 AM

Marketplace > Checkout > WooCommerce products

Screenshot 2025-01-31 at 11 10 37 AM

Referrals > Dashboard empty state

Screenshot 2025-01-31 at 11 10 03 AM

Referrals > FAQ - 2 cards

Screenshot 2025-01-31 at 11 09 51 AM

Partner Directory > Dashboard - Woo card

Screenshot 2025-01-31 at 11 09 33 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested review from jeffgolenski and a team January 31, 2025 06:33
@yashwin yashwin self-assigned this Jan 31, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/a4a/new-woo-logo-changes on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6926 bytes removed 📉 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-partner-directory      -4569 B  (-0.9%)    -2256 B  (-1.4%)
a8c-for-agencies-overview               -3600 B  (-0.3%)    -1819 B  (-0.6%)
a8c-for-agencies-referrals              -3573 B  (-0.3%)    -1606 B  (-0.5%)
a8c-for-agencies-marketplace            -3477 B  (-0.4%)    -1458 B  (-0.5%)
scan                                     +159 B  (+0.0%)      +55 B  (+0.0%)
plans                                    +159 B  (+0.0%)      +55 B  (+0.0%)
jetpack-social                           +159 B  (+0.0%)      +55 B  (+0.0%)
jetpack-search                           +159 B  (+0.0%)      +55 B  (+0.0%)
jetpack-connect                          +159 B  (+0.0%)      +55 B  (+0.0%)
jetpack-cloud-pricing                    +159 B  (+0.0%)      +55 B  (+0.0%)
jetpack-cloud-partner-portal             +159 B  (+0.0%)      +49 B  (+0.0%)
jetpack-cloud-overview                   +159 B  (+0.0%)      +52 B  (+0.0%)
jetpack-cloud-manage-pricing             +159 B  (+0.0%)      +55 B  (+0.0%)
jetpack-cloud-features-comparison        +159 B  (+0.0%)      +55 B  (+0.0%)
jetpack-cloud-agency-dashboard           +159 B  (+0.0%)      +49 B  (+0.0%)
backup                                   +159 B  (+0.0%)      +55 B  (+0.0%)
a8c-for-agencies-sites                   +159 B  (+0.0%)      +55 B  (+0.0%)
a8c-for-agencies-client                  +159 B  (+0.0%)      +57 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -283,7 +284,7 @@ export default function ProductListing( {

{ wooExtensions.length > 0 && (
<ProductListingSection
icon={ <WooLogo width={ 45 } height={ 28 } /> }
icon={ <img width="45px" src={ WooCommerceLogo } alt="WooCommerce" /> }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just update the component here 🤔

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo reference in A4A has been updated, but I'm concerned that we now have more files to monitor when we have another rebrand later.

Since this is time-sensitive, I'll go ahead and approve the PR, but we should publish a P2 and coordinate with the larger group to clean up later. I see multiple Woo logo components. We should probably update those and only use one file.

p1738305279202359-slack-C047ACYM8UQ

Comment on lines +132 to +139
? {
regular: WooCommerceLogo,
light: WooCommerceLogo,
}
: {
regular: WooCommerceProductIcon,
light: WooCommerceProductIcon,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is safe to update this for all environments. If I'm not mistaken, we only referenced Woo product icon in A4A currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies DO NOT MERGE [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants