-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: add Regions/Cities tab #97948
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~121 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
95d7a17
to
72417e7
Compare
@@ -437,7 +437,7 @@ export const normalizers = { | |||
|
|||
// ’ in country names causes google's geo viz to break | |||
return { | |||
label: country.country_full.replace( /’/, "'" ), | |||
label: viewData.location || country.country_full.replace( /’/, "'" ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required change was so small that I didn't make a statsCountryViews
equivalent, like statsLocationViews
, for now. Maybe this will be required when plotting the regions/cities in the geochart map, but let's do it when/if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested and works as expected :)
Related to Automattic/jetpack-roadmap#2093.
Proposed Changes
Regions
/Cities
tab.Why are these changes being made?
Testing Instructions
/stats/day/jetpack.com?flags=stats/locations
Regions
andCities
tabs below it.Regions
Cities
Pre-merge Checklist