Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic blogs: "Default" colour scheme uses incorrect blue for default button colour #98823

Open
definegravity opened this issue Jan 23, 2025 · 4 comments · May be fixed by #99159
Open

Atomic blogs: "Default" colour scheme uses incorrect blue for default button colour #98823

definegravity opened this issue Jan 23, 2025 · 4 comments · May be fixed by #99159
Assignees
@jasmussen
Labels
[Experiment] AI labels added [Feature] Customizer The site customizer for traditional, non-block themes. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage Ticket needs to be triaged [Pri] Normal Schedule for the next available opportuinity. [Status] Auto-allocated [Status] In Progress [Type] Bug When a feature is broken and / or not performing as intended

Comments

@definegravity
Copy link

Context and steps to reproduce

On Atomic sites with the "Default" colour scheme applied, the buttons use Blueberry Blue #3858e for its default state. However, the hover state on the buttons is the expected one.

This happens on every button on the site editor.

Image

CleanShot.2025-01-23.at.09.36.51.mp4

Site owner impact

More than 60% of the total website/platform users

Severity

Minor

What other impact(s) does this issue have?

No revenue impact

If a workaround is available, please outline it here.

I raised this issue in the Dotcom-design Slack channel. Highlighting @jasmussen proposed fixes in the Slack thread:

so the temporary fix is to just apply the modern color scheme manually. Followups include:
fixing the immediate bug so if you choose a color scheme, its colors are correctly applied across themed elements
considering whether to also make modern default on atomic sites we create
longer term, when we can, switching modern to default in vanilla WordPress

Platform

Atomic
@definegravity definegravity added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 23, 2025
@github-actions github-actions bot added [Pri] Normal Schedule for the next available opportuinity. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Customizer The site customizer for traditional, non-block themes. labels Jan 23, 2025
@github-actions GitHub Actions
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Appearance & Themes: The issue pertains to the color scheme used in the Atomic site's appearance, particularly for buttons.
  • [Feature] Global Styles: The problem is associated with the styling and color application across themed elements in the site editor.
  • [Feature] Customizer: The issue relates to the settings involved in customizing the appearance of the site, which includes button colors.

@github-actions github-actions bot added [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Experiment] AI labels added labels Jan 23, 2025
@supernovia
Copy link
Contributor

supernovia commented Jan 23, 2025 •
edited
Loading

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Noting this was the setting at /wp-admin/profile.php
  • I tested with ectoplasm, sunrise, and default blue
  • While other schemes worked, default blue showed #3858e9 instead of #2271b1, only in site editor screens

📌 ACTIONS

  • Triaged

@supernovia supernovia moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 23, 2025
@jasmussen
Copy link
Member

jasmussen commented Jan 30, 2025 •
edited
Loading

At a glance, this appears to be an issue with Help Center CSS:

Image

Specifically, it appears to output these variables, which override and affect the default ones:

Image

Image

@jasmussen jasmussen linked a pull request Jan 31, 2025 that will close this issue
Draft
8 tasks
@jasmussen
Copy link
Member

I have a tentative fix here: #99159 but it needs good testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Experiment] AI labels added [Feature] Customizer The site customizer for traditional, non-block themes. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage Ticket needs to be triaged [Pri] Normal Schedule for the next available opportuinity. [Status] Auto-allocated [Status] In Progress [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Status: Triaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calypso Color Schemes: Scope the accent variable for GB components. Automattic/wp-calypso
4 participants
@jasmussen @supernovia @definegravity @matticbot