Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles: custom "button" colors not reflected on live site #74223

Closed
jp-imagines opened this issue Mar 8, 2023 · 3 comments
Closed

Global styles: custom "button" colors not reflected on live site #74223

jp-imagines opened this issue Mar 8, 2023 · 3 comments
Labels
[Closed] By design Behaviors that are functioning as designed. [Platform] Atomic [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jp-imagines
Copy link

Quick summary

In the Styles pane, under Colors, some themes have a specific "Buttons" color area to set the text/background color for buttons. In some tested themes, the changes may or may not be reflected in the editor, and aren't reflected on the live site.

Steps to reproduce

  1. Activate a block theme – tested on Twenty Twenty-Three and Meraki.
  2. Open the Site Editor (Appearance > Editor).
  3. Add a Buttons block to the current template, and add text and a link to the button to make sure it appears on the live site.
  4. Open the Styles pane, navigate to Colors > Buttons.
  5. Set a custom background or font color. Save changes.

What you expected to happen

Buttons should change to reflect the chosen colors, both in the editor and on the live site.

What actually happened

In Meraki, the button doesn't change in either the editor or the live site. Button block-specific styles (i.e. Styles > Blocks > Button > Colors) do work in both places.

In Twenty Twenty-Three, the editor does reflect the changes, but the live site does not. Button block-specific styles again seems to work in both places.

With the Styles > Colors > Buttons styles modified only, it looks like the default colors are applied just after the custom colors in the theme CSS, causing the custom style to be overwritten.

dvVanZ.png

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Tested only on Atomic so far, and only on these two themes. Reported in 6024659-zd-woothemes.

Using block-specific styles (Styles > Blocks > Button > Colors) seems to work as a workaround. It's not clear from a user's perspective why there's two different places to edit button colors (technically more, as there's also the Buttons block, and a separate Button block styles with no color options).

@jp-imagines jp-imagines added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Mar 8, 2023
@github-actions github-actions bot added [Platform] Atomic [Pri] Low Address when resources are available. labels Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6024659-zen

@dsas
Copy link
Contributor

dsas commented Mar 27, 2023

See WordPress/gutenberg#44931

@cuemarie
Copy link

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on AT: Replicated
  • Tested on Self-Hosted: Replicated
  • Replicated on Core? Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I can replicate this as described on AT site

Self-Hosted Example

Screen.Capture.on.2023-03-28.at.12-18-24.mov

📌 ACTIONS

📌 Message to Author

@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Closed] By design Behaviors that are functioning as designed. labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] By design Behaviors that are functioning as designed. [Platform] Atomic [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants