Outbox: Improve batch handling #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfefferle
added
the
Skip Changelog
github-actions
bot
added
the
[Focus] Compatibility
obenland
reviewed
Feb 7, 2025
* add some actions * fix phpdoc * Use "Unreleased" instead of version number * Add readme * Switch actions props @obenland * renamed action names * fix phpdoc * fix phpdoc * fix phpdoc * fix namings * fix phpcs issues
We'll do that in a separate PR
* Stream: Only surface errors in Outbox processing Also adds support for comment and user types. * Add changelog * fix readme * update to new batch processing * fix phpcs * fix phpcs * re-use wordings from the rest controllers * fix phpcs * restructure the output to match the errors * revert latest changes * Fixed changelog --------- Co-authored-by: Matthias Pfefferle <pfefferle@users.noreply.github.com>
Makes it a bit easier to see what's happening when reading the code.
* Outbox Batch: Only pass outbox id to jobs * Remove unnecessary imports
This allows us to filter by ID and to better debug by title.
obenland
force-pushed
the
improve/outbox-data
branch
from
f4ab80b to
39a3a1c
Compare
obenland
reviewed
Feb 11, 2025
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
obenland
reviewed
Feb 11, 2025
|
We currently don't seem to account for the blog user's reposts |
|
@obenland what do you mean? all the |
|
Right, I would have expected those to also be canceled and the Outbox item published |
|
Ah, that is what you meant! makes sense! |
obenland
reviewed
Feb 11, 2025
obenland
reviewed
Feb 12, 2025
obenland
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a new item is added to the Outbox, every pending item of the same type will be "invalidated". This way, we ensure that older
Updates won't be published if there is already a newer one.Aside from that, this PR allows us to filter by ID and to better debug by title.