Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra Fields: Fix rel me count #1241

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Extra Fields: Fix rel me count #1241

wants to merge 5 commits into from

Conversation

obenland
Copy link
Member

@obenland obenland commented Feb 2, 2025 •
edited
Loading

Multiple calls to ActivityPub\Model\Blog::get_attachment() result in multiple me values getting added to the rel attribute. No more!

Proposed changes:

  • Removes rel me filter after adding it so they don't get stacked.
  • Fixes a possible undefined variable warning.
  • Adds unit test.

Other information:

  • Have you written new tests for your changes, if applicable?

@obenland obenland self-assigned this Feb 2, 2025
@obenland obenland requested a review from a team February 2, 2025 07:05
@obenland obenland marked this pull request as ready for review February 2, 2025 07:05
@obenland obenland changed the title Blog Model: Fix rel me count Extra Fields: Fix rel me count Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@obenland obenland

Labels
[Feature] Collections [Status] In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@obenland