Add WeChat Pay to checkout #10381
Merged
Add WeChat Pay to checkout #10381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
danielmx-dev
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +54 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
danielmx-dev
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Most of this looks well and works fine, however I added a few comments that should be addressed.
Another issue that I noticed is that if you just close the modal without authorizing/failing the charge you'll be redirected to /checkout/undefined, I think that should be fixed in the client/checkout/classic/3ds-flow-handling.js file.
|
Thanks @danielmx-dev
I'm planning to handle this in #10385 along with the implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10103
Changes proposed in this Pull Request
This adds WeChat Pay to checkout.
Testing instructions
Local Server*
Testing requires that the
feat/add-wechat-pay-supportbranch is applied on your local server.${site_id}- your site's ID from the Jetpack connection - you can also get that value from you local table:wcpayserver/wcpay_accounts. wpcom_blog_id):Currently, you'll be redirected to a generic WooCommerce order received page. Though, the original checkout page will redirect to a fully detailed order received page. This will be address in upcoming issues.
Inspect orders and transaction for appropriate details such as payment method title, logos, order notes, and order status.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge