Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev versions #903

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from
Open

fix dev versions #903

wants to merge 13 commits into from

Conversation

bcotrim
Copy link
Contributor

@bcotrim bcotrim commented Feb 6, 2025

Related issues

The reported issue is caused by an error while parsing the commit hash in the dev builds.
This PR suggest a change that makes dev builds follow a correct versioning convention by using -dev${number} format.
We currently already follow that convention on other builds, for example, -beta1, -beta2, etc...
By using the commit count since the latest release we maintain the ability to track which commit generated that version.

Notes:

  • The approval of this PR requires changes in the studio-app/updates endpoint.
  • After releasing a version (e.g., 1.3.3), we should immediately update package.json to the next intended version (e.g., 1.3.4). This ensures dev builds are correctly labeled with the version they're working towards (e.g., 1.3.4-dev1) rather than appearing as development builds of the just-released version.

Proposed Changes

  • Changed development version format from -dev.HASH to -devN (where N is commit count since last release)
  • Updated version counting to use latest release tag (excluding pre-release tags) instead of latest tag
  • Added backward compatibility to handle both -dev.HASH and -devN formats
  • Updated version handling in build scripts and runtime checks
  • Modified artifact naming to use new version format

New dev version on macOS:
image

New dev version on Windows:
image

Testing Instructions

  1. Test the version generation:
node scripts/prepare-dev-build-version.mjs
  1. Check the generated version in package.json:
cat package.json | grep version
  1. Test the releases manifest generation:
IS_DEV_BUILD=true node scripts/generate-releases-manifest.mjs
  1. Check the releases manifest
cat out/releases.json | jq
  1. Test the fastlane distribution (in dry-run mode):
DRY_RUN=true BUILDKITE_BUILD_NUMBER=test-build bundle exec fastlane distribute_dev_build

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@bcotrim bcotrim requested a review from a team February 6, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant