Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
The reported issue is caused by an error while parsing the commit hash in the dev builds.
This PR suggest a change that makes dev builds follow a correct versioning convention by using
-dev${number}
format.We currently already follow that convention on other builds, for example,
-beta1
,-beta2
, etc...By using the commit count since the latest release we maintain the ability to track which commit generated that version.
Notes:
studio-app/updates
endpoint.1.3.3
), we should immediately updatepackage.json
to the next intended version (e.g.,1.3.4
). This ensures dev builds are correctly labeled with the version they're working towards (e.g.,1.3.4-dev1
) rather than appearing as development builds of the just-released version.Proposed Changes
New dev version on macOS:
![image](https://private-user-images.githubusercontent.com/8320845/410936977-c2304628-d915-4d4b-ac9f-a9777b83d0ef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMTQ4NDgsIm5iZiI6MTczOTIxNDU0OCwicGF0aCI6Ii84MzIwODQ1LzQxMDkzNjk3Ny1jMjMwNDYyOC1kOTE1LTRkNGItYWM5Zi1hOTc3N2I4M2QwZWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMTkwOTA4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjE3ZTBlNTNkYjMzYWVkZjliNmFhNWJmNjMzZTg5NDcwMGY4YjE5Y2E0MzY4NDRhNjJmYzc3ZWZkYmQxMjMxOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.l1dtUsoOucZFMdwkmtW3momVHlZ7gOJKI5PZzkpRrYw)
New dev version on Windows:
![image](https://private-user-images.githubusercontent.com/8320845/410937727-f4c4f991-65fa-4e4a-bf59-9048d8c54e90.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMTQ4NDgsIm5iZiI6MTczOTIxNDU0OCwicGF0aCI6Ii84MzIwODQ1LzQxMDkzNzcyNy1mNGM0Zjk5MS02NWZhLTRlNGEtYmY1OS05MDQ4ZDhjNTRlOTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMTkwOTA4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2I5ZmZiZGFjMDVkYjJhYTUwZjljNGQ0MTc2NjgxOTI1NTg5MzJmYTRkNThiY2RhZTI3Y2IwMDRjYzE5MDg2ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.2SwplkTm-D3rJDkWuF16nxmNZ2xOw-onmZDCp4AUpb4)
Testing Instructions
cat package.json | grep version
cat out/releases.json | jq
DRY_RUN=true BUILDKITE_BUILD_NUMBER=test-build bundle exec fastlane distribute_dev_build
Pre-merge Checklist