New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid removing snapshots when switching between users #834

Closed

sejas wants to merge 0 commits into trunk from update/keep-saved-snapshots-between-users

Member

sejas commented Jan 23, 2025 •

edited

Loading

Warning

WIP, this draft PR just started and is incomplete
The Proposed Changes are the plan not a reality

Related issues

Fixes https://github.com/Automattic/dotcom-forge/issues/7516

Proposed Changes

Let's keep all the snapshots in appData
Let's add a new field userId
Let's filter in the UI the snapshots that belong to the current user
Let's figure it out what snapshots should be "removed" from appData and when.
Updated tests

Testing Instructions

Run npm start
Authenticate with user A
Create a demo site
Log out
Authenticate with user B
Observe you don't see any demo site
Log out
Authenticate with user A again
Observe you see the demo site you've created in step 3

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?

sejas self-assigned this

ivan-ottinger self-assigned this

ivan-ottinger closed this

ivan-ottinger force-pushed the update/keep-saved-snapshots-between-users branch from e92933e to b1b7df6 Compare

February 14, 2025 09:32

Contributor

ivan-ottinger commented Feb 14, 2025

This is odd. Not sure how this PR got closed. I only aimed to rebase it and then continue working on. 😕 Sorry about that.

I will create a new one.

wojtekn deleted the update/keep-saved-snapshots-between-users branch

February 17, 2025 08:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet