-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Deno 2.1 in tests #15183
chore: use Deno 2.1 in tests #15183
Conversation
fix(schema): handle bitwise operators on Int32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though it seems deno now requires "implicit js" files to have package.json "type": "commonjs"
as seen in the failing tests:
info: Deno supports CommonJS modules in .cjs files, or when the closest
package.json has a "type": "commonjs" option.
hint: Rewrite this module to ESM,
or change the file extension to .cjs,
or add package.json next to the file with "type": "commonjs" option,
or pass --unstable-detect-cjs flag to detect CommonJS when loading.
docs: https://docs.deno.com/go/commonjs
This should be a non-breaking change as (at least in node) a absense of the type
field should imply commonjs
.
We should be safe to add In the interest of caution, I'll move this back to 8.10. |
Summary
We're using an out-of-date version of Deno, should test against latest
Examples