types(connection): explicitly export connect(), createConnection() #15181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hasezoey
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGTM. To my knowledge, if something is in a declare module block, it shouldnt matter if it has export or not and still be accessible.
Edit: it seems to be a deno bug denoland/deno#27042, and this PR likely will not affect anything because of it.
|
Closing since this is unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #15178
Summary
Shouldn't be necessary to export these functions because they should be in global scope, but it shouldn't cause any problems and being explicit may help IDEs pick these up better.
Examples