refactor: remove dotenv and axios from dev dependencies #15157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove 2 quick dev deps. dotenv isn't used in Mongoose, I think it was accidentally installed by the TypeScript benchmark. axios is just used for one dev-only HTTP request, figure we can easily replace that with fetch(). Technically Mongoose 8 allows node engines down to v16.20.1 and fetch is only available starting in Node 17, but the script that uses axios is dev-only so we don't need to be as strict about engine support. If this can save us a dependabot PR per month, I think that's worth it.
Examples