CSS Minification: Decline to minify files containing unicode escapes like \f178 #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a bug that happens when minifying files like WP's dashicons.css.
It uses unicode escapes like so:
The current engine turns these into unicode codepoints, then renders them in utf-8 bytes. If the browser decides to interpret the file as ASCII, or another non-utf8 encoding, then the user will see 文字化け (mojibake) instead of their icon.
It has been difficult to find an engine that hits all three points of:
While we evaluate other options, this PR changes the behavior to skip minifying files that contain unicode escape sequences. While this gives up some minification benefits, it ensures the user will always see icons as intended.