Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides the Blaze badge on the Stats page when the feature is disabled #43048

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

sbarbosa
Copy link
Contributor

Fixes Automattic/wp-calypso#101987

We are displaying the Blaze link on the Stats page when the Blaze feature is off; if users click it, they will end up on an invalid page. The main problem is that the site and user connection are now handled separately, and it's more common to land on this case. (Blaze needs both connections to work correctly).

Proposed changes:

Include the can_blaze flag as one of the initial parameters for the Jetpack Stats module (Odyssey app).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

You will need to have a site with some stats, so try to access the posts a couple of times before starting the test.

  • Access any self-hosted and navigate to Jetpack->Stats
  • Verify that you see the Blaze badge on any of the posts from the "Post & Pages" section:
    Screenshot 2025-04-11 at 5 02 40 PM
  • Now disconnect your user from WPCOM (just the user)
  • Go back to Jetpack->Stats and verify that you no longer see the Blaze Badge.

@sbarbosa sbarbosa requested a review from kangzj April 11, 2025 20:04
@sbarbosa sbarbosa self-assigned this Apr 11, 2025
Copy link
Contributor

github-actions bot commented Apr 11, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/blaze-badge-stats-page branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/blaze-badge-stats-page
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/blaze-badge-stats-page

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Apr 11, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Apr 11, 2025
@sbarbosa sbarbosa removed the request for review from kangzj April 11, 2025 20:14
@sbarbosa sbarbosa added [Status] In Progress and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 11, 2025
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/stats-admin/src/class-odyssey-config-data.php 110/112 (98.21%) 0.03% 0 💚

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats: do not display Blaze icon when user is not connected
1 participant