-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate geo location module #41193
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
public function sanitize_coordinate( $coordinate ) { | ||
if ( ! $coordinate ) { | ||
return null; | ||
_deprecated_class( 'Jetpack_Geo_Location', '$$next-version', '' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only show the deprecation warning if the theme supports the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me, just left a typo fix suggestion 👍
projects/plugins/jetpack/modules/geo-location/class.jetpack-geo-location.php
Outdated
Show resolved
Hide resolved
…o-location.php Co-authored-by: Karen Attfield <karenlattfield@gmail.com>
* Deprecate Jetpack geo location module * changelog * Prevent linting error * Fix linting error * Update projects/plugins/jetpack/modules/geo-location/class.jetpack-geo-location.php Co-authored-by: Karen Attfield <karenlattfield@gmail.com> --------- Co-authored-by: Karen Attfield <karenlattfield@gmail.com>
Fixes https://github.com/Automattic/vulcan/issues/604
Proposed changes:
This PR removes the geolocation module from the Jetpack plugin and adds a deprecation warning for the
Jetpack_Geo_Location
class.The feature enables users to tag posts with geolocation data (in Calypso) and include the information in RSS feeds, meta tags, and Geo microformat following post content.
Initially tackled in this PR: #40895. This PR keeps the includes to prevent potential fatals, as hinted here: #40895 (comment)
Given the scope of the feature, no deprecation warning is issued.
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Note: I haven't been able to tag posts with geolocation data in Calypso. Let's at least verify the PR doesn't break posts and that deprecation warnings are issued.