Only run GB 19.8 hotfix for non-admin users

[p-jackson]

Fixes Automattic/wp-calypso#98450

Proposed changes:

• Ensure the GB 19.8 hotfix (added here Gutenberg 19.8.0 hotfix: don't show the template-locked rendering mode for pages #40664) is only applied for non-admin users

The original GB 19.8 bug (WordPress/gutenberg#68110) is that loading the page editor fails for non-admin users. A fix is coming in GB 20, but we applied a hotfix in #40664 since breaking the page editor for non-admins is a blocking bug.

However the bugfix changed behaviour in the site editor for admin users. Automattic/wp-calypso#98450. The site editor, rather than opening the whole site template, instead defaulted to opening the home page in the site editor.

This PR attempts to keep a fix for both issues by only applying the hotfix for non-admin users.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Reproduce the bug
  • As a site admin, add a page to your site
  • Go to Settings > Reader and set your page as the homepage
  • Open the site editor
  • The editor doesn't show the full site layout, only the page content of the front page
• Test Fix
  • Apply the change to a WoA or simple site
  • Re-load the site editor. You should now wee the full page layout
  • Create a test user with an Editor role
  • Open a page in the page editor
  • The page editor should load correctly

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the hotfix-template-locked-bug-2 branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin hotfix-template-locked-bug-2
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[fushar]

Tested with admin and Editor roles and it works as described. Nice 👍