Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/33301 form checkbox field #40848

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

enejb
Copy link
Member

@enejb enejb commented Jan 3, 2025

Fixes #33301

Currently when a user is editing the radio buttons or the multi line checkbox and they switch between the different
previews ( mobile, tablet) they end us seeing dots instead of checkboxes or radio buttons.

This is due to the rendering of the styles variables not being set yet.

Proposed changes:

  • This PR fixes the issue by setting assigning a default height and width for the checkbox sizes.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Load up this PR.
  2. Add page with a form.
  3. Add multi select input ( radio or checkbox or both)
  4. Notice that when you toggle between previews ( mobile, tablet ) that the form still looks like expected.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/33301-form-checkbox-field branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/33301-form-checkbox-field
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Block] Contact Form Form block (also see Contact Form label) label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Feature] Contact Form [Package] Forms [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 3, 2025
@enejb enejb requested a review from a team January 4, 2025 17:29
@enejb enejb added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review labels Jan 4, 2025
@simison
Copy link
Member

simison commented Jan 6, 2025

This is due to the rendering of the styles variables not being set yet.

Do you know why they're not available in editor yet at that point, and should they?

Copy link
Contributor

@edanzer edanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For radio controls, I confirmed the issue and then confirmed the fix.

For checkboxes, I wasn't able to duplicate the original issue, and I also don't see CSS changes that apply to checkboxes? Should I be seeing checkboxes rendered as dots when on trunk?

For select dropdowns, I see css changes for font size. I assume that's just to reduce the font size on mobile previews (and consistent with the sizing for the other rules updated here).

Approving as everything is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form: Forms Display Bullets Instead of Checkbox/Radio Options in Editor
3 participants