-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/33301 form checkbox field #40848
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Do you know why they're not available in editor yet at that point, and should they? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For radio controls, I confirmed the issue and then confirmed the fix.
For checkboxes, I wasn't able to duplicate the original issue, and I also don't see CSS changes that apply to checkboxes? Should I be seeing checkboxes rendered as dots when on trunk?
For select dropdowns, I see css changes for font size. I assume that's just to reduce the font size on mobile previews (and consistent with the sizing for the other rules updated here).
Approving as everything is working as expected.
Fixes #33301
Currently when a user is editing the radio buttons or the multi line checkbox and they switch between the different
previews ( mobile, tablet) they end us seeing dots instead of checkboxes or radio buttons.
This is due to the rendering of the styles variables not being set yet.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: