Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaze: Fix external icon alignment on "Blaze this Post" button #40825

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

mehmoodak
Copy link
Member

@mehmoodak mehmoodak commented Jan 2, 2025

Proposed changes:

  • Fix external icon alignment on "Blaze this Post" button.
Before After
image image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Automattic/wp-calypso#95884

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Choose a public site (i.e. not Private or Coming Soon).
    • If it's a Simple site, download the branch to your sandbox with bin/jetpack-downloader test jetpack calypso-95884/fix-blaze-post-icon-alignment, and sandbox the site and s0.wp.com.
  • On the site, create a new page draft or revert an existing test page to draft.
  • Publish the page and verify the icon alignment on "Blaze this page" button.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the calypso-95884/fix-blaze-post-icon-alignment branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack calypso-95884/fix-blaze-post-icon-alignment
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin calypso-95884/fix-blaze-post-icon-alignment
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 2, 2025
@mehmoodak mehmoodak force-pushed the calypso-95884/fix-blaze-post-icon-alignment branch from f8981af to c7a2179 Compare January 2, 2025 14:40
@mehmoodak mehmoodak self-assigned this Jan 3, 2025
@mehmoodak mehmoodak added the [Type] Bug When a feature is broken and / or not performing as intended label Jan 3, 2025
@mehmoodak mehmoodak marked this pull request as ready for review January 3, 2025 11:14
@mehmoodak mehmoodak added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 3, 2025
@mehmoodak mehmoodak linked an issue Jan 3, 2025 that may be closed by this pull request
@mehmoodak mehmoodak requested a review from a team January 6, 2025 14:51
@mehmoodak
Copy link
Member Author

@jeherve After merging the PR, are there any additional steps I should take for deployment?

@jeherve
Copy link
Member

jeherve commented Jan 6, 2025

@mehmoodak After merging, you will receive a Slack ping inviting you to deploy the changes to WordPress.com Simple.

@mehmoodak mehmoodak merged commit 4113d7b into trunk Jan 6, 2025
63 of 64 checks passed
@mehmoodak mehmoodak deleted the calypso-95884/fix-blaze-post-icon-alignment branch January 6, 2025 18:18
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Blaze [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blaze this post external icon alignment
2 participants