-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all prompts to remove premium styles automatically work #40818
base: trunk
Are you sure you want to change the base?
Conversation
…in state on the frontend.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
return false; | ||
} | ||
|
||
// TODO find a way to PUT from the frontend preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this comment. I was in READ mode on sandbox.
data-blog-id="<?php echo esc_attr( (string) $blog_id ); ?>" | ||
data-global-styles-id="<?php echo esc_attr( (string) $global_styles_id ); ?>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a first pass, but thinking of alternatives to exposing blog and global styles id to frontend.
Via a query e.g., ?reset-global-styles=true
? Then the PHP could do all the work, and also double check that the user is logged in, has privileges etc.
If it fails for whatever reason, then we could render the link to the help docs.
This is just a hack test to find a way to reset styles from a logged in state on the frontend.
Kapture.2025-01-03.at.17.33.24.mp4
See: Automattic/wp-calypso#97730
Fixes #
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: