Priority indicators: update logic to match new priority matrix #40672

jeherve · 2024-12-18T19:15:47Z

Note

Follow-up to #40501
I'll merge #40501 and its equivalents in our different repos that use the action once I have a review on this PR.

Proposed changes:

We now ask different questions in our issue templates:
#40501

This commit updates the logic to match the new questions and answers. It also captures the optional extra information ("other impact(s)") an issue can have, since that info can bump the severity, and in turn the priority, of an issue.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See pfVjQF-su-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

This can be tested in a fork.

Here is an example:
jeherve#197

We now ask different questions in our issue templates: #40501 This commit updates the logic to match the new questions and answers. It also captures the optional extra information ("other impact(s)") an issue can have, since that info can bump the severity, and in turn the priority, of an issue. See pfVjQF-su-p2

github-actions · 2024-12-18T19:16:43Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

tbradsha

Looks good to me!

inaikem · 2024-12-19T06:11:10Z

Looks good to me 🙂

anomiex · 2024-12-19T17:10:18Z

projects/github-actions/repo-gardening/src/utils/parse-content/find-priority.js

+			if (
+				( extra === 'Individual site owner revenue' || extra === 'Agency or developer revenue' ) &&
+				severity !== 'Critical'
+			) {
+				severity = 'Major';
+			} else if ( extra === 'Platform revenue' ) {
+				severity = 'Critical';
+			}


You're allowing multiple selections for the additional-impact in #40501. This logic assumes they can select only one.

That's a good point, I had missed that. Fixed in 26f59a8

anomiex · 2024-12-19T17:15:13Z

projects/github-actions/repo-gardening/src/utils/parse-content/find-priority.js

-	return 'TBD';
+	debug(
+		`find-priority: ${
+			priority === 'TBD' ? 'No ' : ' '


If priority got changed, this will produce

find-priority: priority indicators found. Priority set to Whatever.

Should there be something other than just a space in the else case?

I updated that in 2737b64

…g-priority-indicators

See Automattic/wp-calypso#97049 (comment)

See #40672 (comment)

…g-priority-indicators

anomiex

Looks ok, haven't tested. One comment inline.

anomiex · 2025-01-14T18:12:35Z

projects/github-actions/repo-gardening/src/utils/parse-content/find-priority.js

-			return impact === 'All' || impact === 'Most (> 50%)' ? 'Normal' : 'Low';
+		// Folks can provide additional information that can bump severity.
+		// We also do not want that extra information to downgrade the severity.
+		if ( extra !== '' && extra !== '_No response_' && ! extras.includes( 'No revenue impact' ) ) {


If someone selects both "No revenue impact" and "Platform revenue" for some reason, I note it'll ignore the latter in favor of the former. Is that intended?

That's an interesting use case. I don't expect anyone to pick those 2 options together, but given that "No revenue impact" is the last option in the field, I feel comfortable saying that it should top the other options you picked before that.

* Priority indicators: update logic to match new priority matrix We now ask different questions in our issue templates: Automattic/jetpack#40501 This commit updates the logic to match the new questions and answers. It also captures the optional extra information ("other impact(s)") an issue can have, since that info can bump the severity, and in turn the priority, of an issue. See pfVjQF-su-p2 * Update impact wording See Automattic/wp-calypso#97049 (comment) * Be more explicity in final logged priority message See Automattic/jetpack#40672 (comment) * Support multiple potential extra details that can bump pri See Automattic/jetpack#40672 (comment) Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12787245820 Upstream-Ref: Automattic/jetpack@e3b32ec

jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Dec 18, 2024

jeherve self-assigned this Dec 18, 2024

jeherve requested review from inaikem and a team December 18, 2024 19:16

github-actions bot added [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management labels Dec 18, 2024

tbradsha previously approved these changes Dec 18, 2024

View reviewed changes

anomiex reviewed Dec 19, 2024

View reviewed changes

kraftbj added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 7, 2025

jeherve added 3 commits January 13, 2025 15:55

Merge remote-tracking branch 'origin/trunk' into update/repo-gardenin…

a925c27

…g-priority-indicators

Update impact wording

e6aed39

See Automattic/wp-calypso#97049 (comment)

Be more explicity in final logged priority message

2737b64

See #40672 (comment)

jeherve dismissed tbradsha’s stale review via 2737b64 January 13, 2025 15:05

Support multiple potential extra details that can bump pri

26f59a8

See #40672 (comment)

jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 14, 2025

jeherve requested a review from anomiex January 14, 2025 11:12

Merge remote-tracking branch 'origin/trunk' into update/repo-gardenin…

d3f536a

…g-priority-indicators

anomiex approved these changes Jan 14, 2025

View reviewed changes

jeherve merged commit e3b32ec into trunk Jan 15, 2025
57 checks passed

jeherve deleted the update/repo-gardening-priority-indicators branch January 15, 2025 11:21

github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Priority indicators: update logic to match new priority matrix #40672

Priority indicators: update logic to match new priority matrix #40672

jeherve commented Dec 18, 2024

github-actions bot commented Dec 18, 2024 •

edited

Loading

tbradsha left a comment

inaikem commented Dec 19, 2024

anomiex Dec 19, 2024

jeherve Jan 14, 2025

anomiex Dec 19, 2024 •

edited

Loading

jeherve Jan 14, 2025

anomiex left a comment

anomiex Jan 14, 2025

jeherve Jan 15, 2025

Priority indicators: update logic to match new priority matrix #40672

Priority indicators: update logic to match new priority matrix #40672

Conversation

jeherve commented Dec 18, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Dec 18, 2024 • edited Loading

tbradsha left a comment

Choose a reason for hiding this comment

inaikem commented Dec 19, 2024

anomiex Dec 19, 2024

Choose a reason for hiding this comment

jeherve Jan 14, 2025

Choose a reason for hiding this comment

anomiex Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

jeherve Jan 14, 2025

Choose a reason for hiding this comment

anomiex left a comment

Choose a reason for hiding this comment

anomiex Jan 14, 2025

Choose a reason for hiding this comment

jeherve Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot commented Dec 18, 2024 •

edited

Loading

anomiex Dec 19, 2024 •

edited

Loading