Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: add feature as possible recommendations #40639

Merged
merged 13 commits into from
Jan 1, 2025

Conversation

IanRamosC
Copy link
Contributor

@IanRamosC IanRamosC commented Dec 17, 2024

Proposed changes:

  • This PR updates the frontend of My Jetpack in order to display feature modules as possible recommendations. The product cards were adapted to handle feature and their various statuses.

NOTE: the new feature cards work similar to how the product cards work. There's an issue where the state isn't immediately reflected when we, for example, activate a module. That behavior should be fixed in a follow-up.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Spin up a JN site with Jetpack Beta pointing to this branch and enable sandbox access
  • Go to Jetpack Constants and update JETPACK__SANDBOX_DOMAIN to your sandbox domain
  • Checkout this branch in your sandbox: 168603-ghe-Automattic/wpcom
  • Connect My Jetpack, and wait until you see the recommendations survey
  • Check "Grow my site" and wait until you see the recommendations
  • Confirm that you can see and interact with "Related Posts" and "Newsletter"

@IanRamosC IanRamosC changed the base branch from trunk to add/feature-recommendations December 17, 2024 02:31
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/feature-recommendations-cards branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/feature-recommendations-cards
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Base automatically changed from add/feature-recommendations to trunk December 18, 2024 18:54
@IanRamosC IanRamosC force-pushed the add/feature-recommendations-cards branch from 0a09fde to c12225d Compare December 23, 2024 01:54
@IanRamosC IanRamosC self-assigned this Dec 27, 2024
@IanRamosC IanRamosC marked this pull request as ready for review December 27, 2024 01:59
Copy link
Contributor

@robertsreberski robertsreberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that functionality, it works good and seems reliable. I am aware it was not easy to combine free features and products.

I do see the state of the product updating, it just has a long delay 🤔 Anyways, I agree with leaving it out of scope of this PR, and resolve it in the follow up task.

CleanShot 2024-12-30 at 17 41 20

@IanRamosC IanRamosC merged commit c9e3921 into trunk Jan 1, 2025
73 checks passed
@IanRamosC IanRamosC deleted the add/feature-recommendations-cards branch January 1, 2025 15:47
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants