Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: fix home page stat card spacing #40623

Merged
merged 21 commits into from
Dec 18, 2024

Conversation

nateweller
Copy link
Contributor

Proposed changes:

  • Use flex gap to space home page stat cards, the current selector does not work due to cards being wrapped in an extra <div>.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Proof Read / Check Tests

@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Dec 15, 2024
@nateweller nateweller requested a review from a team December 15, 2024 20:14
@nateweller nateweller self-assigned this Dec 15, 2024
@github-actions github-actions bot added the [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. label Dec 15, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 15, 2024
@nateweller nateweller force-pushed the update/protect/threat-icons branch from 82263e8 to b5020dd Compare December 16, 2024 02:00
@nateweller nateweller force-pushed the fix/protect/home-stat-card-gap branch from 7aadefb to cc4dc36 Compare December 16, 2024 02:00
@nateweller nateweller force-pushed the update/protect/threat-icons branch from b5020dd to dd8fb7f Compare December 16, 2024 03:23
@nateweller nateweller force-pushed the fix/protect/home-stat-card-gap branch from cc4dc36 to 6cf16bd Compare December 16, 2024 03:24
@nateweller nateweller force-pushed the update/protect/threat-icons branch from dd8fb7f to 37c57b3 Compare December 16, 2024 04:14
@nateweller nateweller force-pushed the fix/protect/home-stat-card-gap branch from 6cf16bd to b13df3f Compare December 16, 2024 04:15
@nateweller nateweller force-pushed the update/protect/threat-icons branch from 37c57b3 to de0a8c3 Compare December 16, 2024 16:29
@nateweller nateweller force-pushed the fix/protect/home-stat-card-gap branch from b13df3f to 4335e70 Compare December 16, 2024 16:31
Comment on lines 42 to 46
<<<<<<< HEAD
const showResults = !! status.threats.length || hasHistory;
=======
const showResults = status.threats.length || hasHistory;
>>>>>>> 1850b0c9a6 (Protect: only show Threats DataViews when scan is in progress or has results to show)
Copy link
Contributor

@dkmyta dkmyta Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced in the base PR.

Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from needing some conflicts fixed.

@nateweller nateweller force-pushed the update/protect/threat-icons branch from 7e0bea3 to 243b439 Compare December 17, 2024 23:39
@nateweller nateweller force-pushed the fix/protect/home-stat-card-gap branch from 4335e70 to 9a6e7ee Compare December 17, 2024 23:40
Base automatically changed from update/protect/threat-icons to add/protect/core December 18, 2024 20:19
@nateweller nateweller merged commit 2a3f2fe into add/protect/core Dec 18, 2024
2 of 3 checks passed
@nateweller nateweller deleted the fix/protect/home-stat-card-gap branch December 18, 2024 20:20
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants